Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intendeduse select to use is_active filter by default #541

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

henrinie-nc
Copy link
Contributor

No description provided.

@juho-kettunen-nc
Copy link
Contributor

There was some discussion in daily about this topic: in some parts of the application we want to see also the inactive intended uses:

  • advanced search
  • reports
  • django-admin

The only place where the inactives need to be filtered out is the summary edit page.

Is this default problematic then?

@henrinie-nc
Copy link
Contributor Author

There was some discussion in daily about this topic: in some parts of the application we want to see also the inactive intended uses:

* advanced search

* reports

* django-admin

The only place where the inactives need to be filtered out is the summary edit page.

Is this default problematic then?

This function is used by the select component for intendeduse, and that is used in places where it is filtered by service unit, e.g. on the lease page.
It should not affect the advanced search, which gets all the intended uses from the OPTIONS.

@henrinie-nc henrinie-nc merged commit 5a3b1b4 into develop Nov 12, 2024
3 checks passed
@henrinie-nc henrinie-nc deleted the MVJ-542-intended-use-isactive branch November 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants